Add ExcludeKey option to TextFormatter #1433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningyougang
force-pushed
the
add-exclude-key-option
branch
from
cd432c8 to
aedfb7c
Compare
ningyougang
commented
May 15, 2024
| @@ -331,9 +337,14 @@ func (f *TextFormatter) appendValue(b *bytes.Buffer, value interface{}) { | |||
| stringVal = fmt.Sprint(value) | |||
| } | |||
|
|
|||
| if !f.needsQuoting(stringVal) { | |||
| // write value without quoting directly when ExcludeKey is true | |||
| if f.ExcludeKey { | |||
There was a problem hiding this comment.
If configure ExcludeKey as true, just write value without quoting directly, otherwise, the logs will be as below
"0001-01-01T00:00:00Z" warning "message"
ningyougang
force-pushed
the
add-exclude-key-option
branch
from
aedfb7c to
a886e5b
Compare
ningyougang
commented
May 15, 2024
| b.WriteString(stringVal) | ||
| } else { | ||
| b.WriteString(fmt.Sprintf("%q", stringVal)) | ||
| } |
There was a problem hiding this comment.
Keep the same logic as before when ExcludeKey is false(this is default)
|
Can someone review this PR? |
Ilovemesomehim1
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AS-IS (
ExcludeKey : false, this is default)TO-BE (after applied
ExcludeKey : true)I think this is a common case, when
some log collector agentcollect the logs from file or standard output, does not need the startingKey(e.g.time=)